diff options
| author | Joe Mou <dev@mou.fo> | 2026-09-10 00:53:48 -0400 |
|---|---|---|
| committer | Joe Mou <dev@mou.fo> | 2026-09-10 01:01:04 -0400 |
| commit | ca0291062362b3036077cb14bd8d13aca1cde62d (patch) | |
| tree | 0385ba222e6edd7392d5c9971761be8db356fc71 | |
| parent | 84ac17c0c2cc694dd481dac25f5cc898cdaf0f3d (diff) | |
Redirect /notifications instead of scraping it as an owner
A signed-out request for github.com/notifications is bounced to a login
page, so the owner route followed that redirect and left the visitor on
/login. Hand the path over to GitHub before it reaches the route.
| -rw-r--r-- | README.md | 4 | ||||
| -rw-r--r-- | src/app.test.ts | 7 | ||||
| -rw-r--r-- | src/app.ts | 5 |
3 files changed, 14 insertions, 2 deletions
@@ -28,8 +28,8 @@ Not implemented: - Actions, checks, projects, packages, discussions, and gists - Profile tabs other than the overview (repositories, projects, packages, people, sponsoring) -- Anything requiring an account: signing in, starring, commenting, editing, or - any other write action +- Anything requiring an account: signing in, notifications, starring, + commenting, editing, or any other write action - Private repositories ## Browser extension redirects diff --git a/src/app.test.ts b/src/app.test.ts index 8720a23..c028e1b 100644 --- a/src/app.test.ts +++ b/src/app.test.ts @@ -441,6 +441,13 @@ describe("redirects to GitHub", () => { ); }); + it("should redirect notifications without scraping them as a profile", async () => { + const res = await app.request("http://cgithub.example/notifications?query=is%3Aunread"); + + assert.strictEqual(res.status, 200); + assert.match(await res.text(), /url=https:\/\/github.com\/notifications\?query=is%3Aunread"/); + }); + it("should redirect raw file requests to raw.githubusercontent.com", async () => { const res = await app.request("http://cgithub.example/actions/deploy-pages/raw/main/README.md"); @@ -95,6 +95,11 @@ export function createApp(eta: Eta) { return c.render("home.eta"); }); + // Exclusion that immediately redirects to GitHub. + app.get("/notifications", async (c) => { + return redirectToGitHub(c); + }); + // GitHub's global search, which we only serve when it is scoped to a single // repository: strip the qualifier and let that repository's search route // decide what to do with the rest. |
